Allow depth first search when enumerating credentials #406

conorpp · 2020-03-27T04:31:32Z

Fixes clients that enumerate DFS (Chrome tool)
Fixed some potential issues for enumerating RP's

rgerganov · 2020-03-27T06:38:18Z

fido2/ctap.c

@@ -1597,45 +1685,37 @@ uint8_t ctap_cred_mgmt(CborEncoder * encoder, uint8_t * request, int length)
 }
 if (CM.cmd == CM_cmdRPBegin)
 {
- curr_rk_ind = 0;
+ curr_rk_ind = -1;
+ curr_rp_ind = scan_for_next_rp(-1);
 rp_count = count_unique_rks();


count_unique_rks is confusing as it is counting RPs, not RKs
can we reuse scan_for_next_rp and get rid of count_unique_rks?

Good point, will refactor now

conorpp added 2 commits March 27, 2020 00:28

allow depth-first-search and account for interleaved RK's

6196481

change parsing TAG_CM to TAG_PARSE

5d2acf1

rgerganov reviewed Mar 27, 2020

View reviewed changes

refactor credmgmt

ec52ca2

conorpp merged commit 5f8a9a4 into master Mar 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow depth first search when enumerating credentials #406

Allow depth first search when enumerating credentials #406

conorpp commented Mar 27, 2020

rgerganov Mar 27, 2020

conorpp Mar 27, 2020

Allow depth first search when enumerating credentials #406

Allow depth first search when enumerating credentials #406

Conversation

conorpp commented Mar 27, 2020

rgerganov Mar 27, 2020

Choose a reason for hiding this comment

conorpp Mar 27, 2020

Choose a reason for hiding this comment